lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 08 Dec 2020 15:18:31 +0100
From:   Toke Høiland-Jørgensen <>
To:     Jakub Kicinski <>
Cc:     "David S. Miller" <>,
        Daniel Borkmann <>,
        Alexei Starovoitov <>,
        Andrii Nakryiko <>,
        Martin KaFai Lau <>,
        Song Liu <>, Yonghong Song <>,
        John Fastabend <>,
        KP Singh <>,
        Jesper Dangaard Brouer <>,
        "Michael S. Tsirkin" <>,
        Romain Perier <>,
        Allen Pais <>,
        Grygorii Strashko <>,
        Simon Horman <>,
        "Gustavo A. R. Silva" <>,
        Lorenzo Bianconi <>,
        Wei Yongjun <>,
        Jiri Benc <>,,,,
Subject: Re: [PATCH bpf v2 0/7] selftests/bpf: Restore to
 working order

Toke Høiland-Jørgensen <> writes:

> This series restores the selftest to working order. It seems a
> number of subtle behavioural changes have crept into various subsystems which
> broke in a number of ways. Most of these are fairly benign
> changes where small adjustments to the test script seems to be the best fix, but
> one is an actual kernel bug that I've observed in the wild caused by a bad
> interaction between xdp_attachment_flags_ok() and the rework of XDP program
> handling in the core netdev code.
> Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the reminder of
> the patches are adjustments to, including a new feature for
> netdevsim to force a BPF verification fail. Please see the individual patches
> for details.
> Changelog:
> v2:
> - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach()
> - Better packing of struct nsim_dev

Hi Jakub

Any feedback on v2? Would be great to get it merged before the final
5.10 release :)


Powered by blists - more mailing lists