netdev - Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZdPi9S-dgH+=q_ZP3BM6QdDkGgJR6o0ndSrRMTBAJVT7EjkQ@mail.gmail.com>
Date:   Tue, 8 Dec 2020 15:50:15 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     subashab@...eaurora.org
Cc:     Jakub Kicinski <kuba@...nel.org>, stranche@...eaurora.org,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

Hi Subash,

On Tue, 8 Dec 2020 at 09:19, <subashab@...eaurora.org> wrote:
>
> >> What about just returning an error on NETDEV_PRECHANGEMTU notification
> >> to prevent real device MTU change while virtual rmnet devices are
> >> linked? Not sure there is a more proper and thread safe way to manager
> >> that otherwise.
> >
> > Can't you copy what vlan devices do?  That'd seem like a reasonable and
> > well tested precedent, no?
>
> Could you try this patch. I've tried addressing most of the conditions
> here.
> I haven't seen any issues with updating the MTU when rmnet devices are
> linked.

Thanks, could you submit it as new regular patch, I'll give you my tested-by.

Regards,
Loic