netdev - Re: [PATCH net v2] mptcp: print new line in mptcp_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201207174638.3740a734@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Mon, 7 Dec 2020 17:46:38 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jianguo Wu <wujianguo106@....com>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        mathew.j.martineau@...ux.intel.com, pabeni@...hat.com,
        davem@...emloft.net
Subject: Re: [PATCH net v2] mptcp: print new line in mptcp_seq_show() if
 mptcp isn't in use

On Sat, 5 Dec 2020 15:56:33 +0800 Jianguo Wu wrote:
> From: Jianguo Wu <wujianguo@...natelecom.cn>
> 
> When do cat /proc/net/netstat, the output isn't append with a new line, it looks like this:
> [root@...alhost ~]# cat /proc/net/netstat
> ...
> MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@...alhost ~]#
> 
> This is because in mptcp_seq_show(), if mptcp isn't in use, net->mib.mptcp_statistics is NULL,
> so it just puts all 0 after "MPTcpExt:", and return, forgot the '\n'.
> 
> After this patch:
> 
> [root@...alhost ~]# cat /proc/net/netstat
> ...
> MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0
> [root@...alhost ~]#
> 
> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
> Signed-off-by: Jianguo Wu <wujianguo@...natelecom.cn>
> Acked-by: Florian Westphal <fw@...len.de>

Applied, thanks!