lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Dec 2020 03:07:02 +0000 From: Qiang Zhao <qiang.zhao@....com> To: Rasmus Villemoes <rasmus.villemoes@...vas.dk>, Jakub Kicinski <kuba@...nel.org> CC: Leo Li <leoyang.li@....com>, "David S. Miller" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Vladimir Oltean <vladimir.oltean@....com> Subject: RE: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications On 06/12/2020 05:12, Rasmus Villemoes <rasmus.villemoes@...vas.dk> wrote: > -----Original Message----- > From: Rasmus Villemoes <rasmus.villemoes@...vas.dk> > Sent: 2020年12月6日 5:12 > To: Jakub Kicinski <kuba@...nel.org> > Cc: Leo Li <leoyang.li@....com>; David S. Miller <davem@...emloft.net>; > Qiang Zhao <qiang.zhao@....com>; netdev@...r.kernel.org; > linuxppc-dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org; > linux-arm-kernel@...ts.infradead.org; Vladimir Oltean > <vladimir.oltean@....com> > Subject: Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and > simplifications > > On 05/12/2020 21.53, Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > >> While trying to figure out how to allow bumping the MTU with the > >> ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > >> bunch of issues of varying importance - some are outright bug fixes, > >> while most are a matter of simplifying the code to make it more > >> accessible. > >> > >> At the end of digging around the code and data sheet to figure out > >> how it all works, I think the MTU issue might be fixed by a > >> one-liner, but I'm not sure it can be that simple. It does seem to > >> work (ping -s X works for larger values of X, and wireshark confirms > >> that the packets are not fragmented). > >> > >> Re patch 2, someone in NXP should check how the hardware actually > >> works and make an updated reference manual available. > > > > Looks like a nice clean up on a quick look. > > > > Please separate patches 1 and 11 (which are the two bug fixes I see) > > I think patch 2 is a bug fix as well, but I'd like someone from NXP to comment. It 's ok for me. Best Regards, Qiang Zhao
Powered by blists - more mailing lists