lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Dec 2020 08:43:42 +0200 From: Leon Romanovsky <leon@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Pablo Neira Ayuso <pablo@...filter.org>, Jiri Benc <jbenc@...hat.com>, Cong Wang <xiyou.wangcong@...il.com>, Jamal Hadi Salim <jhs@...atatu.com>, Stephen Hemminger <stephen@...workplumber.org>, Eric Dumazet <edumazet@...gle.com>, George McCollister <george.mccollister@...il.com>, Oleksij Rempel <o.rempel@...gutronix.de> Subject: Re: [RFC PATCH net-next 01/13] RDMA/mlx4: remove bogus dev_base_lock usage On Mon, Dec 07, 2020 at 01:59:07AM +0200, Vladimir Oltean wrote: > The dev_base_lock does not protect dev->dev_addr, so it serves no > purpose here. > > Cc: Leon Romanovsky <leon@...nel.org> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > --- > drivers/infiniband/hw/mlx4/main.c | 3 --- > 1 file changed, 3 deletions(-) Agree with the description, most likely the authors wanted to ensure that "dev" doesn't disappear, but it is not correct way to do and not needed in that flow. Thanks for the patch, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists