netdev - Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Dec 2020 08:45:05 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>
Cc:     Thomas Wagner <thwa1@....de>, linux-can@...r.kernel.org,
        kernel@...gutronix.de, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional
 addressing

On 12/8/20 7:07 PM, Jakub Kicinski wrote:
> On Tue, 8 Dec 2020 13:54:28 +0100 Oliver Hartkopp wrote:
>> On 05.12.20 22:09, Jakub Kicinski wrote:
>>> On Sat, 5 Dec 2020 21:56:33 +0100 Marc Kleine-Budde wrote:  
>>>> On 12/5/20 9:33 PM, Jakub Kicinski wrote:  
>>>>>> What about the (incremental?) change that Thomas Wagner posted?
>>>>>>
>>>>>> https://lore.kernel.org/r/20201204135557.55599-1-thwa1@web.de  
>>>>>
>>>>> That settles it :) This change needs to got into -next and 5.11.  
>>>>
>>>> Ok. Can you take patch 1, which is a real fix:
>>>>
>>>> https://lore.kernel.org/linux-can/20201204133508.742120-2-mkl@pengutronix.de/  
>>>
>>> Sure! Applied that one from the ML (I assumed that's what you meant).
>>
>> I just double-checked this mail and in fact the second patch from Marc's 
>> pull request was a real fix too:
>>
>> https://lore.kernel.org/linux-can/20201204133508.742120-3-mkl@pengutronix.de/
> 
> Ack, I thought it was a fix to some existing code but it's a fix to
> ISO-TP so we should probably get it in before someone start depending
> on existing behavior - Marc should I apply that one directly, too?

Yes, please take that patch directly.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)