netdev - RE: [PATCH net-next] net: freescale: dpaa: simplify the return dpaa_eth_refill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Dec 2020 09:24:30 +0000
From:   "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: freescale: dpaa: simplify the return
 dpaa_eth_refill_bpools()

> -----Original Message-----
> From: Zheng Yongjun <zhengyongjun3@...wei.com>
> Sent: 09 December 2020 11:21
> To: davem@...emloft.net; netdev@...r.kernel.org
> Cc: kuba@...nel.org; linux-kernel@...r.kernel.org; Madalin Bucur
> <madalin.bucur@....com>; Zheng Yongjun <zhengyongjun3@...wei.com>
> Subject: [PATCH net-next] net: freescale: dpaa: simplify the return
> dpaa_eth_refill_bpools()
> 
> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index cb7c028b1bf5..edc8222d96dc 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -1599,17 +1599,13 @@ static int dpaa_eth_refill_bpools(struct dpaa_priv
> *priv)
>  {
>  	struct dpaa_bp *dpaa_bp;
>  	int *countptr;
> -	int res;
> 
>  	dpaa_bp = priv->dpaa_bp;
>  	if (!dpaa_bp)
>  		return -EINVAL;
>  	countptr = this_cpu_ptr(dpaa_bp->percpu_count);
> -	res  = dpaa_eth_refill_bpool(dpaa_bp, countptr);
> -	if (res)
> -		return res;
> 
> -	return 0;
> +	return dpaa_eth_refill_bpool(dpaa_bp, countptr);
>  }
> 
>  /* Cleanup function for outgoing frame descriptors that were built on Tx
> path,
> --
> 2.22.0

Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>