netdev - Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c31de6ba-e758-1c42-b662-d1787ea8237c@redhat.com>
Date:   Wed, 9 Dec 2020 17:30:23 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     wangyunjian <wangyunjian@...wei.com>,
        "mst@...hat.com" <mst@...hat.com>
Cc:     "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Lilijun (Jerry)" <jerry.lilijun@...wei.com>,
        xudingke <xudingke@...wei.com>
Subject: Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path


On 2020/12/8 上午10:32, Jason Wang wrote:
>
> On 2020/12/7 下午9:38, wangyunjian wrote:
>> I think the newly added code is easy to miss this problem, so I want to
>> copy ubuf_info until we're sure there's no errors.
>>
>> Thanks,
>> Yunjian
>
>
> But isn't this actually a disabling of zerocopy?
>
> Thanks
>
>

Sorry, I misread the patch.

Please send a formal version, and let's move the discussion there.

Thanks