netdev - Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 09 Dec 2020 10:40:59 +0100
From:   Martin Schiller <ms@....tdt.de>
To:     Xie He <xie.he.0141@...il.com>
Cc:     Andrew Hendry <andrew.hendry@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux X25 <linux-x25@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm
 handling

On 2020-12-09 10:17, Xie He wrote:
> On Wed, Dec 9, 2020 at 1:01 AM Xie He <xie.he.0141@...il.com> wrote:
>> 
>> On Wed, Nov 25, 2020 at 10:36 PM Martin Schiller <ms@....tdt.de> 
>> wrote:
>> >
>> >         switch (nb->state) {
>> >         case X25_LINK_STATE_0:
>> > -               nb->state = X25_LINK_STATE_2;
>> > -               break;
>> >         case X25_LINK_STATE_1:
>> >                 x25_transmit_restart_request(nb);
>> >                 nb->state = X25_LINK_STATE_2;
>> 
>> What is the reason for this change? Originally only the connecting
>> side will transmit a Restart Request; the connected side will not and
>> will only wait for the Restart Request to come. Now both sides will
>> transmit Restart Requests at the same time. I think we should better
>> avoid collision situations like this.
> 
> Oh. I see. Because in other patches we are giving L2 the ability to
> connect by itself, both sides can now appear here to be the
> "connected" side. So we can't make the "connected" side wait as we did
> before.

Right.
By the way: A "Restart Collision" is in practice a very common event to
establish the Layer 3.