lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 09 Dec 2020 14:57:42 +0100
From:   Toke Høiland-Jørgensen <>
To:     Jakub Kicinski <>
Cc:     "David S. Miller" <>,
        Daniel Borkmann <>,
        Alexei Starovoitov <>,
        Andrii Nakryiko <>,
        Martin KaFai Lau <>,
        Song Liu <>, Yonghong Song <>,
        John Fastabend <>,
        KP Singh <>,
        Jesper Dangaard Brouer <>,
        "Michael S. Tsirkin" <>,
        Romain Perier <>,
        Allen Pais <>,
        Grygorii Strashko <>,
        Simon Horman <>,
        "Gustavo A. R. Silva" <>,
        Lorenzo Bianconi <>,
        Wei Yongjun <>,
        Jiri Benc <>,,,,
Subject: [PATCH bpf v4 6/7] selftests/bpf/ reset ethtool
 features after failed setting

From: Toke Høiland-Jørgensen <>

When setting the ethtool feature flag fails (as expected for the test), the
kernel now tracks that the feature was requested to be 'off' and refuses to
subsequently disable it again. So reset it back to 'on' so a subsequent
disable (that's not supposed to fail) can succeed.

Fixes: 417ec26477a5 ("selftests/bpf: add offload test based on netdevsim")
Signed-off-by: Toke Høiland-Jørgensen <>
 tools/testing/selftests/bpf/ |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/ b/tools/testing/selftests/bpf/
index 51a5e4d939cc..2128fbd8414b 100755
--- a/tools/testing/selftests/bpf/
+++ b/tools/testing/selftests/bpf/
@@ -946,6 +946,7 @@ try:
     start_test("Test disabling TC offloads is rejected while filters installed...")
     ret, _ = sim.set_ethtool_tc_offloads(False, fail=False)
     fail(ret == 0, "Driver should refuse to disable TC offloads with filters installed...")
+    sim.set_ethtool_tc_offloads(True)
     start_test("Test qdisc removal frees things...")

Powered by blists - more mailing lists