netdev - Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201209165319.GA8699@netronome.com>
Date:   Wed, 9 Dec 2020 17:53:22 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] nfp: silence set but not used warning with
 IPV6=n

On Wed, Dec 09, 2020 at 08:18:21AM -0800, Jakub Kicinski wrote:
> Test robot reports:
> 
> drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':
> drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
>   477 |  struct ipv6hdr *ipv6h;
>       |                  ^~~~~
> In file included from include/linux/compiler_types.h:65,
>                     from <command-line>:
> drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
>   208 | # define fallthrough                    __attribute__((__fallthrough__))
>       |                                         ^~~~~~~~~~~~~
> drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
>   299 |   fallthrough;
>       |   ^~~~~~~~~~~
> 
> Use the IPv6 header in the switch, it doesn't matter which header
> we use to read the version field.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks Jakub,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>