netdev - Re: [PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9275ad90-ee7e-6e23-6a33-bb0f7a2e2eeb@pensando.io>
Date:   Wed, 9 Dec 2020 10:02:51 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>, drivers@...sando.io,
        davem@...emloft.net, kuba@...nel.org, leon@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] drivers: net: ionic: simplify the return
 expression of ionic_set_rxfh()

On 12/8/20 5:53 AM, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

Acked-by: Shannon Nelson <snelson@...sando.io>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 35c72d4a78b3..0832bedcb3b4 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -738,16 +738,11 @@ static int ionic_set_rxfh(struct net_device *netdev, const u32 *indir,
>   			  const u8 *key, const u8 hfunc)
>   {
>   	struct ionic_lif *lif = netdev_priv(netdev);
> -	int err;
>   
>   	if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP)
>   		return -EOPNOTSUPP;
>   
> -	err = ionic_lif_rss_config(lif, lif->rss_types, key, indir);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return ionic_lif_rss_config(lif, lif->rss_types, key, indir);
>   }
>   
>   static int ionic_set_tunable(struct net_device *dev,