lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 01:17:27 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net, kuba@...nel.org, vivien.didelot@...il.com, f.fainelli@...il.com, j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net, netdev@...r.kernel.org Subject: Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support On Wed, Dec 09, 2020 at 03:23:40PM +0100, Andrew Lunn wrote: > On Wed, Dec 09, 2020 at 12:53:26PM +0200, Vladimir Oltean wrote: > > On Wed, Dec 09, 2020 at 09:37:39AM +0100, Tobias Waldekranz wrote: > > > I will remove `struct dsa_lag` in v4. > > > > Ok, thanks. > > It would be nice if you could also make .port_lag_leave return an int code. > > I've not looked at the code, but how can it fail, other than something > probably fatal with communication with the hardware. And what should > the rest of the stack do? Recreate what is just destroyed? And does > that really work? What can fail is memory allocation, which other drivers might need to do when they rebalance the remaining ports in the LAG.
Powered by blists - more mailing lists