netdev - Re: [PATCH net] net: sched: incorrect Kconfig dependencies on Netfilter modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201209155008.42b12cfa@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Date:   Wed, 9 Dec 2020 15:50:08 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sched: incorrect Kconfig dependencies on
 Netfilter modules

On Tue,  8 Dec 2020 21:47:07 +0100 Pablo Neira Ayuso wrote:
> - NET_ACT_CONNMARK and NET_ACT_CTINFO only require conntrack support.
> - NET_ACT_IPT only requires NETFILTER_XTABLES symbols, not
>   IP_NF_IPTABLES. After this patch, NET_ACT_IPT becomes consistent
>   with NET_EMATCH_IPT. NET_ACT_IPT dependency on IP_NF_IPTABLES predates
>   Linux-2.6.12-rc2 (initial git repository build).
> 
> Fixes: 22a5dc0e5e3e ("net: sched: Introduce connmark action")
> Fixes: 24ec483cec98 ("net: sched: Introduce act_ctinfo action")
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Doesn't seem too critical to remove unnecessary dependencies.

Applied to net-next, thanks!