lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Dec 2020 06:42:53 +0000 From: "Zouwei (Samuel)" <zou_wei@...wei.com> To: Leon Romanovsky <leon@...nel.org>, Jakub Kicinski <kuba@...nel.org> CC: "saeedm@...dia.com" <saeedm@...dia.com>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: 答复: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> ok, I will add the Fixes line and send the v2 soon. -----邮件原件----- 发件人: Leon Romanovsky [mailto:leon@...nel.org] 发送时间: 2020年12月9日 14:21 收件人: Jakub Kicinski <kuba@...nel.org> 抄送: Zouwei (Samuel) <zou_wei@...wei.com>; saeedm@...dia.com; davem@...emloft.net; netdev@...r.kernel.org; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org 主题: Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > Remove including <generated/utsrelease.h> that don't need it. > > > > Signed-off-by: Zou Wei <zou_wei@...wei.com> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > index 989c70c..82ecc161 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > @@ -30,7 +30,6 @@ > > * SOFTWARE. > > */ > > > > -#include <generated/utsrelease.h> > > #include <linux/mlx5/fs.h> > > #include <net/switchdev.h> > > #include <net/pkt_cls.h> Jakub, You probably doesn't have latest net-next. In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));" line. The patch is ok, but should have Fixes line. Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") Thanks > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’: > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’? > 66 | strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); > | ^~~~~~~~~~~ > | CSS_RELEASED > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each > undeclared identifier is reported only once for each function it > appears in > make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error > 1 > make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2 > make[4]: *** [drivers/net/ethernet/mellanox] Error 2 > make[3]: *** [drivers/net/ethernet] Error 2 > make[2]: *** [drivers/net] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [drivers] Error 2 > make: *** [__sub-make] Error 2
Powered by blists - more mailing lists