netdev - Re: [PATCH] wireguard: avoid double unlikely() notation when using IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9pOZRtzqBELQTG6tONiWxJJU8KQhSxWST2T_ReCX3ZNYQ@mail.gmail.com>
Date:   Thu, 10 Dec 2020 10:37:18 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Antonio Quartulli <a@...table.cc>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        WireGuard mailing list <wireguard@...ts.zx2c4.com>,
        Netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()

On Thu, Dec 10, 2020 at 9:56 AM Antonio Quartulli <a@...table.cc> wrote:
>
> The definition of IS_ERR() already applies the unlikely() notation
> when checking the error status of the passed pointer. For this
> reason there is no need to have the same notation outside of
> IS_ERR() itself.
>
> Clean up code by removing redundant notation.

Thanks for the patch. I can confirm this doesn't change the codgen at all.

I've queued this up in wireguard's staging tree, and I'll push it back
out as part of the next series.

Jason