netdev - Re: [PATCH bpf-next v4 2/5] selftests/bpf: xsk selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPLEeBbLhGATeSbA46SxEpgVXKXm__OcgjPhNKcvzoCnSk7sdA@mail.gmail.com>
Date:   Thu, 10 Dec 2020 11:55:49 +0000
From:   Weqaar Janjua <weqaar.janjua@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>, ast@...nel.org,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Weqaar Janjua <weqaar.a.janjua@...el.com>, shuah@...nel.org,
        skhan@...uxfoundation.org, linux-kselftest@...r.kernel.org,
        Anders Roxell <anders.roxell@...aro.org>,
        jonathan.lemon@...il.com
Subject: Re: [PATCH bpf-next v4 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

On Wed, 9 Dec 2020 at 18:29, Yonghong Song <yhs@...com> wrote:
>
>
>
> On 12/7/20 1:53 PM, Weqaar Janjua wrote:
> > Adds following tests:
> >
> > 1. AF_XDP SKB mode
> >     Generic mode XDP is driver independent, used when the driver does
> >     not have support for XDP. Works on any netdevice using sockets and
> >     generic XDP path. XDP hook from netif_receive_skb().
> >     a. nopoll - soft-irq processing
> >     b. poll - using poll() syscall
> >
> > Signed-off-by: Weqaar Janjua <weqaar.a.janjua@...el.com>
> > ---
> >   tools/testing/selftests/bpf/Makefile       |   3 +-
> >   tools/testing/selftests/bpf/test_xsk.sh    |  39 +-
> >   tools/testing/selftests/bpf/xdpxceiver.c   | 979 +++++++++++++++++++++
> >   tools/testing/selftests/bpf/xdpxceiver.h   | 153 ++++
> >   tools/testing/selftests/bpf/xsk_prereqs.sh |  16 +
> >   5 files changed, 1187 insertions(+), 3 deletions(-)
> >   create mode 100644 tools/testing/selftests/bpf/xdpxceiver.c
> >   create mode 100644 tools/testing/selftests/bpf/xdpxceiver.h
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index 6a1ddfe68f15..944ae17a39ed 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -82,7 +82,8 @@ TEST_PROGS_EXTENDED := with_addr.sh \
> >   # Compile but not part of 'make run_tests'
> >   TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \
> >       flow_dissector_load test_flow_dissector test_tcp_check_syncookie_user \
> > -     test_lirc_mode2_user xdping test_cpp runqslower bench bpf_testmod.ko
> > +     test_lirc_mode2_user xdping test_cpp runqslower bench bpf_testmod.ko \
> > +     xdpxceiver
>
> Could you have a patch to put xdpxceiver in .gitignore?
>
> I see below:
> Untracked files:
>    (use "git add <file>..." to include in what will be committed)
>          tools/testing/selftests/bpf/xdpxceiver
>
ACK, patch on the list now

> >
> >   TEST_CUSTOM_PROGS = urandom_read
> >