netdev - [PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Dec 2020 23:43:29 +1000
From:   Pavana Sharma <pavana.sharma@...i.com>
To:     andrew@...n.ch
Cc:     ashkan.boldaji@...i.com, clang-built-linux@...glegroups.com,
        davem@...emloft.net, devicetree@...r.kernel.org,
        f.fainelli@...il.com, gregkh@...uxfoundation.org,
        kbuild-all@...ts.01.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, lkp@...el.com, marek.behun@....cz,
        netdev@...r.kernel.org, pavana.sharma@...i.com, robh+dt@...nel.org,
        vivien.didelot@...il.com
Subject: [PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Hi Andrew,

> For v10 i said:

> > What value does the comment add?

> I don't remember you replying. Why is 5gbase-r special and it needs a
> comment, saying the same thing in CAPS LETTERS? What value is there in
> the CAPS LETTERS string?

There isn't anything special regarding 5gbase-r apart from another supported
speed.
So, I will remove the comment from [PATCH 1 & 2] and keep it similar to other
(1000/2500) speed options.

Thanks,
Pavana