lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 17:07:28 +0200 From: Maxim Mikityanskiy <maximmi@...dia.com> To: Dan Carpenter <dan.carpenter@...cle.com>, <kbuild@...ts.01.org>, "Maxim Mikityanskiy" <maximmi@...lanox.com>, "David S. Miller" <davem@...emloft.net>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us> CC: <lkp@...el.com>, <kbuild-all@...ts.01.org>, <netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, Jakub Kicinski <kuba@...nel.org>, "Tariq Toukan" <tariqt@...lanox.com> Subject: Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB On 2020-12-10 10:28, Dan Carpenter wrote: > Hi Maxim, > > > url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5 > config: i386-randconfig-m021-20201209 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@...el.com> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com> > > smatch warnings: > net/sched/sch_htb.c:1310 htb_dump_class_stats() error: we previously assumed 'cl->leaf.q' could be null (see line 1300) > > vim +1310 net/sched/sch_htb.c > > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1289 static int > 87990467d387f92 Stephen Hemminger 2006-08-10 1290 htb_dump_class_stats(struct Qdisc *sch, unsigned long arg, struct gnet_dump *d) > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1291 { > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1292 struct htb_class *cl = (struct htb_class *)arg; > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1293 struct htb_sched *q = qdisc_priv(sch); > 338ed9b4de57c4b Eric Dumazet 2016-06-21 1294 struct gnet_stats_queue qs = { > 338ed9b4de57c4b Eric Dumazet 2016-06-21 1295 .drops = cl->drops, > 3c75f6ee139d464 Eric Dumazet 2017-09-18 1296 .overlimits = cl->overlimits, > 338ed9b4de57c4b Eric Dumazet 2016-06-21 1297 }; > 6401585366326fc John Fastabend 2014-09-28 1298 __u32 qlen = 0; > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1299 > 5dd431b6b92c0db Paolo Abeni 2019-03-28 @1300 if (!cl->level && cl->leaf.q) > ^^^^^^^^^^ > Check for NULL Well, I don't think this is real... I don't see any possibility how cl->leaf.q can be NULL for a leaf class. However, I'll add a similar check below anyway. Also, I fixed the sparse warnings from the other email (sorry for them!) I will wait for some time to collect more comments (hopefully from people, not only from static checkers) and respin with the fixes. > 5dd431b6b92c0db Paolo Abeni 2019-03-28 1301 qdisc_qstats_qlen_backlog(cl->leaf.q, &qlen, &qs.backlog); > 5dd431b6b92c0db Paolo Abeni 2019-03-28 1302 > 0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1303 cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens), > 0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1304 INT_MIN, INT_MAX); > 0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1305 cl->xstats.ctokens = clamp_t(s64, PSCHED_NS2TICKS(cl->ctokens), > 0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1306 INT_MIN, INT_MAX); > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1307 > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1308 if (q->offload) { > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1309 if (!cl->level) { > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 @1310 cl->bstats = cl->leaf.q->bstats; > ^^^^^^^^^^^^ > Unchecked dereference > > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1311 cl->bstats.bytes += cl->bstats_bias.bytes; > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1312 cl->bstats.packets += cl->bstats_bias.packets; > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1313 } else { > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1314 htb_offload_aggregate_stats(q, cl); > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1315 } > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1316 } > 1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1317 > edb09eb17ed89ea Eric Dumazet 2016-06-06 1318 if (gnet_stats_copy_basic(qdisc_root_sleeping_running(sch), > edb09eb17ed89ea Eric Dumazet 2016-06-06 1319 d, NULL, &cl->bstats) < 0 || > 1c0d32fde5bdf11 Eric Dumazet 2016-12-04 1320 gnet_stats_copy_rate_est(d, &cl->rate_est) < 0 || > 338ed9b4de57c4b Eric Dumazet 2016-06-21 1321 gnet_stats_copy_queue(d, NULL, &qs, qlen) < 0) > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1322 return -1; > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1323 > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1324 return gnet_stats_copy_app(d, &cl->xstats, sizeof(cl->xstats)); > ^1da177e4c3f415 Linus Torvalds 2005-04-16 1325 } > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >
Powered by blists - more mailing lists