lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 17:15:30 +0000 From: Shai Malin <smalin@...vell.com> To: Boris Pismenny <borisp@...lanox.com>, "kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "saeedm@...dia.com" <saeedm@...dia.com>, "hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>, "axboe@...com" <axboe@...com>, "kbusch@...nel.org" <kbusch@...nel.org>, "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>, "edumazet@...gle.com" <edumazet@...gle.com> CC: Yoray Zack <yorayz@...lanox.com>, "yorayz@...dia.com" <yorayz@...dia.com>, "boris.pismenny@...il.com" <boris.pismenny@...il.com>, Ben Ben-Ishay <benishay@...lanox.com>, "benishay@...dia.com" <benishay@...dia.com>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Or Gerlitz <ogerlitz@...lanox.com>, "ogerlitz@...dia.com" <ogerlitz@...dia.com>, "Ariel Elior" <aelior@...vell.com>, Michal Kalderon <mkalderon@...vell.com>, "malin1024@...il.com" <malin1024@...il.com> Subject: RE: [PATCH v1 net-next 05/15] nvme-tcp: Add DDP offload control path diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index c0c33320fe65..ef96e4a02bbd 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -14,6 +14,7 @@ #include <linux/blk-mq.h> #include <crypto/hash.h> #include <net/busy_poll.h> +#include <net/tcp_ddp.h> #include "nvme.h" #include "fabrics.h" @@ -62,6 +63,7 @@ enum nvme_tcp_queue_flags { NVME_TCP_Q_ALLOCATED = 0, NVME_TCP_Q_LIVE = 1, NVME_TCP_Q_POLLING = 2, + NVME_TCP_Q_OFFLOADS = 3, }; The same comment from the previous version - we are concerned that perhaps the generic term "offload" for both the transport type (for the Marvell work) and for the DDP and CRC offload queue (for the Mellanox work) may be misleading and confusing to developers and to users. As suggested by Sagi, we can call this NVME_TCP_Q_DDP.
Powered by blists - more mailing lists