netdev - Re: [PATCH net] net: sched: Fix dump of MPLS_OPT_LSE_LABEL attribute in cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Dec 2020 18:47:33 +0100
From:   Davide Caratti <dcaratti@...hat.com>
To:     Guillaume Nault <gnault@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: sched: Fix dump of MPLS_OPT_LSE_LABEL
 attribute in cls_flower

On Wed, 2020-12-09 at 16:48 +0100, Guillaume Nault wrote:
> TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL is a u32 attribute (MPLS label is
> 20 bits long).
> 
> Fixes the following bug:
> 
>  $ tc filter add dev ethX ingress protocol mpls_uc \
>      flower mpls lse depth 2 label 256             \
>      action drop
> 
>  $ tc filter show dev ethX ingress
>    filter protocol mpls_uc pref 49152 flower chain 0
>    filter protocol mpls_uc pref 49152 flower chain 0 handle 0x1
>      eth_type 8847
>      mpls
>        lse depth 2 label 0  <-- invalid label 0, should be 256
>    ...
> 
> Fixes: 61aec25a6db5 ("cls_flower: Support filtering on multiple MPLS Label Stack Entries")
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Reviewed-by: Davide Caratti <dcaratti@...hat.com>