netdev - Re: [PATCH net-next] ice, xsk: Move Rx alloction out of while-loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ+HfNh4LS-25LH0gE0Pun7v=q=8zChmKUaN+hQA_58gwtbZ-g@mail.gmail.com>
Date:   Thu, 10 Dec 2020 18:10:08 +0100
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next] ice, xsk: Move Rx alloction out of while-loop

On Thu, 10 Dec 2020 at 17:20, Maciej Fijalkowski
<maciej.fijalkowski@...el.com> wrote:
>
> On Thu, Dec 10, 2020 at 01:19:15PM +0100, Björn Töpel wrote:
> > From: Björn Töpel <bjorn.topel@...el.com>
> >
> > Instead of trying to allocate for each packet, move it outside the
> > while loop and try to allocate once every NAPI loop.
>
> To rectify above, it wasn't for each packet but per ICE_RX_BUF_WRITE
> cleaned frames (16).
>
> You also have a typo in subject (alloction).
>
> Is spinning a v2 worth it?
>

Sure! I'll rephrase, and resend!

Thanks,
Björn