netdev - Re: [PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201209.161041.1128905467938677328.davem@davemloft.net>
Date:   Wed, 09 Dec 2020 16:10:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     cmi@...dia.com
Cc:     netdev@...r.kernel.org, pablo@...filter.org, kuba@...nel.org,
        roid@...dia.com
Subject: Re: [PATCH net v2] net: flow_offload: Fix memory leak for indirect
 flow block

From: Chris Mi <cmi@...dia.com>
Date: Tue,  8 Dec 2020 10:48:35 +0800

> The offending commit introduces a cleanup callback that is invoked
> when the driver module is removed to clean up the tunnel device
> flow block. But it returns on the first iteration of the for loop.
> The remaining indirect flow blocks will never be freed.
> 
> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
> CC: Pablo Neira Ayuso <pablo@...filter.org>
> Signed-off-by: Chris Mi <cmi@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>
> ---
> v2: - CC relevant people.
Applied, trhanks.