netdev - Re: [PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 09 Dec 2020 19:07:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     drt@...ux.ibm.com
Cc:     kuba@...nel.org, dnbanerg@...ibm.com, ljp@...ux.ibm.com,
        sukadev@...ux.ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ibmvnic: fix rx buffer tracking and index
 management in replenish_rx_pool partial success

From: Dany Madden <drt@...ux.ibm.com>
Date: Wed,  9 Dec 2020 20:53:31 -0500

> From: "Dwip N. Banerjee" <dnbanerg@...ibm.com>
> 
> We observed that in the error case for batched send_subcrq_indirect() the
> driver does not account for the partial success case. This caused Linux to
> crash when free_map and pool index are inconsistent.
> 
> Driver needs to update the rx pools "available" count when some batched
> sends worked but an error was encountered as part of the whole operation.
> Also track replenish_add_buff_failure for statistic purposes.
> 
> Fixes: 4f0b6812e9b9a ("ibmvnic: Introduce batched RX buffer descriptor transmission")
> Signed-off-by: Dwip N. Banerjee <dnbanerg@...ibm.com>
> Reviewed-by: Dany Madden <drt@...ux.ibm.com>

Applied, thanks.