netdev - Re: [PATCH net-next v3 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201210035437.GA1627447@robh.at.kernel.org>
Date:   Wed, 9 Dec 2020 21:54:37 -0600
From:   Rob Herring <robh@...nel.org>
To:     George McCollister <george.mccollister@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/3] dt-bindings: net: dsa: add bindings for
 xrs700x switches

On Mon, Dec 07, 2020 at 04:03:55PM -0600, George McCollister wrote:
> Add documentation and an example for Arrow SpeedChips XRS7000 Series
> single chip Ethernet switches.
> 
> Signed-off-by: George McCollister <george.mccollister@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 74 ++++++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> new file mode 100644
> index 000000000000..05ed36ce02ec
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/dsa/arrow,xrs700x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Arrow SpeedChips XRS7000 Series Switch Device Tree Bindings
> +
> +allOf:
> +  - $ref: dsa.yaml#
> +
> +maintainers:
> +  - George McCollister <george.mccollister@...il.com>
> +
> +description:
> +  The Arrow SpeedChips XRS7000 Series of single chip gigabit Ethernet switches
> +  are designed for critical networking applications. They have up to three
> +  RGMII ports and one RMII port and are managed via i2c or mdio.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - arrow,xrs7003e
> +          - arrow,xrs7003f
> +          - arrow,xrs7004e
> +          - arrow,xrs7004f
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        switch@8 {
> +            compatible = "arrow,xrs7004e";
> +            reg = <0x8>;
> +
> +            status = "okay";

Don't show status in examples.

> +            ports {

ethernet-ports is preferred.

> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +                port@1 {

And ethernet-port

> +                    reg = <1>;
> +                    label = "lan0";
> +                    phy-handle = <&swphy0>;
> +                    phy-mode = "rgmii-id";
> +                };
> +                port@2 {
> +                    reg = <2>;
> +                    label = "lan1";
> +                    phy-handle = <&swphy1>;
> +                    phy-mode = "rgmii-id";
> +                };
> +                port@3 {
> +                    reg = <3>;
> +                    label = "cpu";
> +                    ethernet = <&fec1>;
> +                    fixed-link {
> +                        speed = <1000>;
> +                        full-duplex;
> +                    };
> +                };
> +            };
> +        };
> +    };
> -- 
> 2.11.0
>