lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Dec 2020 07:27:17 +0100 From: Martin Schiller <ms@....tdt.de> To: Xie He <xie.he.0141@...il.com> Cc: Andrew Hendry <andrew.hendry@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Linux X25 <linux-x25@...r.kernel.org>, Linux Kernel Network Developers <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling On 2020-12-09 23:11, Xie He wrote: > On Wed, Dec 9, 2020 at 1:47 AM Xie He <xie.he.0141@...il.com> wrote: >> >> On Wed, Dec 9, 2020 at 1:41 AM Martin Schiller <ms@....tdt.de> wrote: >> > >> > Right. >> > By the way: A "Restart Collision" is in practice a very common event to >> > establish the Layer 3. >> >> Oh, I see. Thanks! > > Hi Martin, > > When you submit future patch series, can you try ensuring the code to > be in a completely working state after each patch in the series? This > makes reviewing the patches easier. After the patches get applied, > this also makes tracing bugs (for example, with "git bisect") through > the commit history easier. Well I thought that's what patch series are for: Send patches that belong together and should be applied together. Of course I will try to make each patch work on its own, but this is not always possible with major changes or ends up in monster patches. And nobody wants that. Martin
Powered by blists - more mailing lists