netdev - Re: [PATCH net-next v2 01/12] gtp: set initial MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Dec 2020 10:38:15 +0100
From:   Harald Welte <laforge@...monks.org>
To:     Jonas Bonn <jonas@...rbonn.se>
Cc:     netdev@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net-next v2 01/12] gtp: set initial MTU

On Fri, Dec 11, 2020 at 01:26:01PM +0100, Jonas Bonn wrote:
> The GTP link is brought up with a default MTU of zero.  This can lead to
> some rather unexpected behaviour for users who are more accustomed to
> interfaces coming online with reasonable defaults.
> 
> This patch sets an initial MTU for the GTP link of 1500 less worst-case
> tunnel overhead.

Thanks, LGTM.  I would probably have gone to a #define or a 'const' variable,
but I guess compilers should be smart enough to figure out that this is
static at compile time even the way you wrote it.

Acked-by: Harald Welte <laforge@...monks.org>

-- 
- Harald Welte <laforge@...monks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)