netdev - Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201213004933.pbjwfltwudvokrej@skbuf>
Date:   Sun, 13 Dec 2020 00:49:33 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>,
        Florian Fainelli <f.fainelli@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH v3 net-next] net: dsa: reference count the host mdb
 addresses

On Sun, Dec 13, 2020 at 01:34:10AM +0100, Andrew Lunn wrote:
> On Sun, Dec 13, 2020 at 12:14:19AM +0000, Vladimir Oltean wrote:
> > On Sun, Dec 13, 2020 at 01:08:55AM +0100, Andrew Lunn wrote:
> > > > > And you need some way to cleanup the allocated memory when the commit
> > > > > never happens because some other layer has said No!
> > > >
> > > > So this would be a fatal problem with the switchdev transactional model
> > > > if I am not misunderstanding it. On one hand there's this nice, bubbly
> > > > idea that you should preallocate memory in the prepare phase, so that
> > > > there's one reason less to fail at commit time. But on the other hand,
> > > > if "the commit phase might never happen" is even a remove possibility,
> > > > all of that goes to trash - how are you even supposed to free the
> > > > preallocated memory.
> > >
> > > It can definitely happen, that commit is never called:
> > >
> > > static int switchdev_port_obj_add_now(struct net_device *dev,
> > >                                       const struct switchdev_obj *obj,
> > >                                       struct netlink_ext_ack *extack)
> > > {
> > >
> > >        /* Phase I: prepare for obj add. Driver/device should fail
> > >          * here if there are going to be issues in the commit phase,
> > >          * such as lack of resources or support.  The driver/device
> > >          * should reserve resources needed for the commit phase here,
> > >          * but should not commit the obj.
> > >          */
> > >
> > >         trans.ph_prepare = true;
> > >         err = switchdev_port_obj_notify(SWITCHDEV_PORT_OBJ_ADD,
> > >                                         dev, obj, &trans, extack);
> > >         if (err)
> > >                 return err;
> > >
> > >         /* Phase II: commit obj add.  This cannot fail as a fault
> > >          * of driver/device.  If it does, it's a bug in the driver/device
> > >          * because the driver said everythings was OK in phase I.
> > >          */
> > >
> > >         trans.ph_prepare = false;
> > >         err = switchdev_port_obj_notify(SWITCHDEV_PORT_OBJ_ADD,
> > >                                         dev, obj, &trans, extack);
> > >         WARN(err, "%s: Commit of object (id=%d) failed.\n", dev->name, obj->id);
> > >
> > >         return err;
> > >
> > > So if any notifier returns an error during prepare, the commit is
> > > never called.
> > >
> > > So the memory you allocated and added to the list may never get
> > > used. Its refcount stays zero.  Which is why i suggested making the
> > > MDB remove call do a general garbage collect. It is not perfect, the
> > > cleanup could be deferred a long time, but is should get removed
> > > eventually.
> > 
> > What would the garbage collection look like?
> 
>         struct dsa_host_addr *a;
> 
>         list_for_each_entry_safe(a, addr_list, list)
> 		if (refcount_read(&a->refcount) == 0) {
> 			list_del(&a->list);
> 			free(a);
> 		}
> 	}

Sorry, this seems a bit absurd. The code is already absurdly complicated
as is. I don't want to go against the current and add more unjustified
nonsense instead of taking a step back, which I should have done earlier.
I thought this transactional API was supposed to help. Though I scanned
the kernel tree a bit and I fail to understand whom it helps exactly.
What I see is that the whole 'transaction' spans only the length of the
switchdev_port_attr_set_now function.

Am I right to say that there is no in-kernel code that depends upon the
switchdev transaction model right now, as it's completely hidden away
from callers? As in, we could just squash the two switchdev_port_attr_notify
calls into one and nothing would functionally change for the callers of
switchdev_port_attr_set?
Why don't we do just that? I might be completely blind, but I am getting
the feeling that this idea has not aged very well.

Florian, has anything happened in the meantime since this commit of yours?

commit 91cf8eceffc131d41f098351e1b290bdaab45ea7
Author: Florian Fainelli <f.fainelli@...il.com>
Date:   Wed Feb 27 16:29:16 2019 -0800

    switchdev: Remove unused transaction item queue

    There are no more in tree users of the
    switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure
    in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API
    and implementation to be switchdev independant").

    Remove this unused code and update the documentation accordingly since.

    Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
    Acked-by: Jiri Pirko <jiri@...lanox.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

There isn't an API to hold this stuff any longer. So let's go back to
the implementation from v2, with memory allocation in the commit phase.
The way forward anyway is probably not to add a garbage collector in
DSA, but to fold the prepare and commit phases into one.