netdev - Re: Incorrect --help / manpage for -color for ip, tc, bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201214080013.6ef78cb7@hermes.local>
Date:   Mon, 14 Dec 2020 08:00:13 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Witold Baryluk <witold.baryluk@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: Incorrect --help / manpage for -color for ip, tc, bridge

On Sat, 12 Dec 2020 20:07:16 +0000
Witold Baryluk <witold.baryluk@...il.com> wrote:

> iproute 5.9.0
> 
> Apparently ip -c is a shortcut to ip -color
> 
> but in tc, tc -c doesn't work, one needs to say tc -col or tc -color
> 
> I understand there is tc -conf, which has tc -c.
> 
> But:
> 
> Help says:
> 
> root@...ian:~# tc
> Usage:    tc [ OPTIONS ] OBJECT { COMMAND | help }
>     tc [-force] -batch filename
> where  OBJECT := { qdisc | class | filter | chain |
>             action | monitor | exec }
>        OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] | -r[aw] |
>             -o[neline] | -j[son] | -p[retty] | -c[olor]
>             -b[atch] [filename] | -n[etns] name | -N[umeric] |
>              -nm | -nam[es] | { -cf | -conf } path }
> 
> this should be:
> 
> root@...ian:~# tc
> Usage:    tc [ OPTIONS ] OBJECT { COMMAND | help }
>     tc [-force] -batch filename
> where  OBJECT := { qdisc | class | filter | chain |
>             action | monitor | exec }
>        OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] | -r[aw] |
>             -o[neline] | -j[son] | -p[retty] | -col[or]
>             -b[atch] [filename] | -n[etns] name | -N[umeric] |
>              -nm | -nam[es] | { -cf | -c[onf] } path }
> 
> 
> ( -c[olor] -> -col[or] )  # also in --help for ip and bridge
> 
> If only -c meaning -conf could be removed, it would be even nicer. -cf
> is already short.
> 
> Additionally in manpage for tc, ip and bridge:
>        -c[color][={always|auto|never}
>               Configure color output. If parameter is omitted or
> always, color output is enabled regardless of stdout state. If
> parameter is auto, stdout is checked to be a terminal be‐
>               fore  enabling  color output. If parameter is never,
> color output is disabled. If specified multiple times, the last one
> takes precedence. This flag is ignored if -json is
>               also given.
> 
> 
> 
> I don't think this is correct either.
> 
> Should be -col[or], not -c[color] (sic!).
> 
> Similar mistakes are in man pages and --help messages also for ip,
> bridge, not just tc.
> 
> 
> Regards,
> Witold

Send a patch to fix it.