netdev - Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae436f90-45b8-ba70-be57-d17641c4f79d@lenovo.com>
Date:   Mon, 14 Dec 2020 13:40:37 -0500
From:   Mark Pearson <markpearson@...ovo.com>
To:     Mario Limonciello <mario.limonciello@...l.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        David Miller <davem@...emloft.net>,
        Aaron Ma <aaron.ma@...onical.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Sasha Netfin <sasha.neftin@...el.com>,
        Aaron Brown <aaron.f.brown@...el.com>,
        Stefan Assmann <sassmann@...hat.com>,
        "darcari@...hat.com" <darcari@...hat.com>,
        "Yijun.Shen@...l.com" <Yijun.Shen@...l.com>,
        "Perry.Yuan@...l.com" <Perry.Yuan@...l.com>,
        "anthony.wong@...onical.com" <anthony.wong@...onical.com>
Subject: Re: Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems
 i219LM

Thanks Hans

On 14/12/2020 13:31, Mark Pearson wrote:
> 
> 
> ------------------------------------------------------------------------
> *From:* Hans de Goede <hdegoede@...hat.com>
> *Sent:* December 14, 2020 13:24
> *To:* Mario Limonciello <mario.limonciello@...l.com>; Jeff Kirsher
> <jeffrey.t.kirsher@...el.com>; Tony Nguyen <anthony.l.nguyen@...el.com>;
> intel-wired-lan@...ts.osuosl.org <intel-wired-lan@...ts.osuosl.org>;
> David Miller <davem@...emloft.net>; Aaron Ma <aaron.ma@...onical.com>;
> Mark Pearson <mpearson@...ovo.com>
> *Cc:* linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>;
> Netdev <netdev@...r.kernel.org>; Alexander Duyck
> <alexander.duyck@...il.com>; Jakub Kicinski <kuba@...nel.org>; Sasha
> Netfin <sasha.neftin@...el.com>; Aaron Brown <aaron.f.brown@...el.com>;
> Stefan Assmann <sassmann@...hat.com>; darcari@...hat.com
> <darcari@...hat.com>; Yijun.Shen@...l.com <Yijun.Shen@...l.com>;
> Perry.Yuan@...l.com <Perry.Yuan@...l.com>; anthony.wong@...onical.com
> <anthony.wong@...onical.com>
> *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems
> i219LM
>  
> Hi All,
> 
<snip>
> 
> ###
> 
> I've added Mark Pearson from Lenovo to the Cc so that Lenovo
> can investigate this issue further.
> 
> Mark, this thread is about an issue with enabling S0ix support for
> e1000e (i219lm) controllers. This was enabled in the kernel a
> while ago, but then got disabled again on vPro / AMT enabled
> systems because on some systems (Lenovo X1C7 and now also X1C8)
> this lead to suspend/resume issues.
> 
> When AMT is active then there is a handover handshake for the
> OS to get access to the ethernet controller from the ME. The
> Intel folks have checked and the Windows driver is using a timeout
> of 1 second for this handshake, yet on Lenovo systems this is
> taking 2 seconds. This likely has something to do with the
> ME firmware on these Lenovo models, can you get the firmware
> team at Lenovo to investigate this further ?
Absolutely - I'll ask them to look into this again.

We did try to make progress with this previously - but it got a bit
stuck and hence the need for these patches....but I believe things may
have changed a bit so it's worth trying again

Mark