netdev - Re: [RFC PATCH net-next 03/16] net: mscc: ocelot: rename ocelot_netdevice_port_event to ocelot_netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201215152730.yozchbn7jo4cdesa@skbuf>
Date:   Tue, 15 Dec 2020 15:27:30 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Tobias Waldekranz <tobias@...dekranz.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [RFC PATCH net-next 03/16] net: mscc: ocelot: rename
 ocelot_netdevice_port_event to ocelot_netdevice_changeupper

On Tue, Dec 15, 2020 at 04:01:32PM +0100, Alexandre Belloni wrote:
> Hi,
> 
> On 08/12/2020 14:07:49+0200, Vladimir Oltean wrote:
> > -static int ocelot_netdevice_port_event(struct net_device *dev,
> > -				       unsigned long event,
> > -				       struct netdev_notifier_changeupper_info *info)
> > +static int ocelot_netdevice_changeupper(struct net_device *dev,
> > +					struct netdev_notifier_changeupper_info *info)
> 
> [...]
> 
> > -		netdev_for_each_lower_dev(dev, slave, iter) {
> > -			ret = ocelot_netdevice_port_event(slave, event, info);
> > -			if (ret)
> > -				goto notify;
> > +			netdev_for_each_lower_dev(dev, slave, iter) {
> > +				ret = ocelot_netdevice_changeupper(slave, event, info);
> > +				if (ret)
> > +					goto notify;
> > +			}
> > +		} else {
> > +			ret = ocelot_netdevice_changeupper(dev, event, info);
> 
> Does that compile?

No it doesn't.

> Shouldn't event be dropped?

It is, but in the next patch. I'll fix it, thanks.