netdev - Re: [Patch bpf-next v2 0/5] bpf: introduce timeout map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bza1tAnAMVw8g4z2UviYqWxgarOXZX2JDTShYyk-NLAo6A@mail.gmail.com>
Date:   Tue, 15 Dec 2020 11:28:57 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Cong Wang <cong.wang@...edance.com>
Subject: Re: [Patch bpf-next v2 0/5] bpf: introduce timeout map

On Mon, Dec 14, 2020 at 12:13 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> From: Cong Wang <cong.wang@...edance.com>
>
> This patchset introduces a new bpf hash map which has timeout.

It's a bit too short a cover letter for a pretty major new type of
hash maps. Please expand on the problem it's trying to solve, how you
tested and benchmarked it, etc.

> Patch 1 is a preparation, patch 2 is the implementation of timeout
> map, patch 3 updates an existing hash map ptr test, patch 4 and
> patch 5 contain two test cases for timeout map.
>
> Please check each patch description for more details.
>
> ---
> v2: fix hashmap ptr test
>     add a test case in map ptr test
>     factor out htab_timeout_map_alloc()
>
> Cong Wang (5):
>   bpf: use index instead of hash for map_locked[]
>   bpf: introduce timeout map
>   selftests/bpf: update elem_size check in map ptr test
>   selftests/bpf: add a test case for bpf timeout map
>   selftests/bpf: add timeout map check in map_ptr tests
>
>  include/linux/bpf_types.h                     |   1 +
>  include/uapi/linux/bpf.h                      |   3 +-
>  kernel/bpf/hashtab.c                          | 301 ++++++++++++++++--
>  kernel/bpf/syscall.c                          |   3 +-
>  tools/include/uapi/linux/bpf.h                |   1 +
>  .../selftests/bpf/progs/map_ptr_kern.c        |  22 +-
>  tools/testing/selftests/bpf/test_maps.c       |  41 +++
>  7 files changed, 340 insertions(+), 32 deletions(-)
>
> --
> 2.25.1
>