netdev - Re: [PATCH] net/connector: Add const qualifier to cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201214192303.32a38c7a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Dec 2020 19:23:03 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Geoff Levand <geoff@...radead.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Evgeniy Polyakov <zbr@...emap.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net/connector: Add const qualifier to cb_id

On Sat, 12 Dec 2020 18:47:01 -0800 Geoff Levand wrote:
> The connector driver never modifies any cb_id passed to it, so add a const
> qualifier to those arguments so callers can declare their struct cb_id as a
> constant object.
> 
> Fixes build warnings like these when passing a constant struct cb_id:
> 
>   warning: passing argument 1 of ‘cn_add_callback’ discards ‘const’ qualifier from pointer target
> 
> Signed-off-by: Geoff Levand <geoff@...radead.org>

This does not apply to net-next. Please rebase against:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/