netdev - Re: [PATCH][c89] wrong usage of compiler constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201214163633.3ece1ff3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Dec 2020 16:36:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     sylvain.bertrand@...eek.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH][c89] wrong usage of compiler constants

On Mon, 14 Dec 2020 16:30:01 +0000 sylvain.bertrand@...eek.net wrote:
> From: Sylvain BERTRAND <sylvain.bertrand@...eek.net>
> 
> Using a c89 compiler fails due some wrong usage of compiler constants.

Are you saying it fails on some known compilers in the code you're
fixing? We have a strong preference to ask contributors to fix
compilers.

> Trivial and harmless fixes.

Code churn, longer lines, and another thing for developers to remember
are not harmless.