netdev - RE: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Dec 2020 07:51:37 +0000
From:   wangyunjian <wangyunjian@...wei.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
CC:     Network Development <netdev@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "Lilijun (Jerry)" <jerry.lilijun@...wei.com>,
        chenchanghu <chenchanghu@...wei.com>,
        xudingke <xudingke@...wei.com>,
        "huangbin (J)" <brian.huangbin@...wei.com>
Subject: RE: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when
 sendmsg fails

> -----Original Message-----
> From: Willem de Bruijn [mailto:willemdebruijn.kernel@...il.com]
> Sent: Tuesday, December 15, 2020 10:46 AM
> To: wangyunjian <wangyunjian@...wei.com>
> Cc: Network Development <netdev@...r.kernel.org>; Michael S. Tsirkin
> <mst@...hat.com>; Jason Wang <jasowang@...hat.com>; Willem de Bruijn
> <willemdebruijn.kernel@...il.com>; virtualization@...ts.linux-foundation.org;
> Lilijun (Jerry) <jerry.lilijun@...wei.com>; chenchanghu
> <chenchanghu@...wei.com>; xudingke <xudingke@...wei.com>; huangbin (J)
> <brian.huangbin@...wei.com>
> Subject: Re: [PATCH net 1/2] vhost_net: fix ubuf refcount incorrectly when
> sendmsg fails
> 
> On Mon, Dec 14, 2020 at 8:59 PM wangyunjian <wangyunjian@...wei.com>
> wrote:
> >
> > From: Yunjian Wang <wangyunjian@...wei.com>
> >
> > Currently the vhost_zerocopy_callback() maybe be called to decrease
> > the refcount when sendmsg fails in tun. The error handling in vhost
> > handle_tx_zerocopy() will try to decrease the same refcount again.
> > This is wrong. To fix this issue, we only call vhost_net_ubuf_put()
> > when vq->heads[nvq->desc].len == VHOST_DMA_IN_PROGRESS.
> >
> > Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
> > Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP
> > driver")
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> 
> Patch looks good to me. Thanks.
> 
> But I think the right Fixes tag would be
> 
> Fixes: 0690899b4d45 ("tun: experimental zero copy tx support")

OK, thanks for the suggestion. I will fix it in next version.