netdev - Re: [PATCH wireless -next] brcmfmac: Delete useless kfree code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871rfpyjho.fsf@codeaurora.org>
Date:   Wed, 16 Dec 2020 15:21:23 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     <arend.vanspriel@...adcom.com>, <franky.lin@...adcom.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <SHA-cyfmac-dev-list@...ineon.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wireless -next] brcmfmac: Delete useless kfree code

Zheng Yongjun <zhengyongjun3@...wei.com> writes:

> The parameter of kfree function is NULL, so kfree code is useless, delete it.
> Therefore, goto expression is no longer needed, so simplify it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  .../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c  | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

You forgot to CC linux-wireless, please resend as v2

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches