netdev - Re: [net-next v5 09/15] net/mlx5: E-switch, Prepare eswitch to handle SF vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201215164753.4f6c4c9c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 15 Dec 2020 16:47:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jason Gunthorpe <jgg@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, David Ahern <dsahern@...nel.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>,
        david.m.ertman@...el.com, dan.j.williams@...el.com,
        kiran.patil@...el.com, gregkh@...uxfoundation.org,
        Vu Pham <vuhuong@...dia.com>, Parav Pandit <parav@...dia.com>,
        Roi Dayan <roid@...dia.com>, Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net-next v5 09/15] net/mlx5: E-switch, Prepare eswitch to
 handle SF vport

On Tue, 15 Dec 2020 01:03:52 -0800 Saeed Mahameed wrote:
> From: Vu Pham <vuhuong@...dia.com>
> 
> Prepare eswitch to handle SF vport during
> (a) querying eswitch functions
> (b) egress ACL creation
> (c) account for SF vports in total vports calculation
> 
> Assign a dedicated placeholder for SFs vports and their representors.
> They are placed after VFs vports and before ECPF vports as below:
> [PF,VF0,...,VFn,SF0,...SFm,ECPF,UPLINK].
> 
> Change functions to map SF's vport numbers to indices when
> accessing the vports or representors arrays, and vice versa.
> 
> Signed-off-by: Vu Pham <vuhuong@...dia.com>
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Roi Dayan <roid@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> index d6c48582e7a8..ad45d20f9d44 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> @@ -212,3 +212,13 @@ config MLX5_SF
>  	Build support for subfuction device in the NIC. A Mellanox subfunction
>  	device can support RDMA, netdevice and vdpa device.
>  	It is similar to a SRIOV VF but it doesn't require SRIOV support.
> +
> +config MLX5_SF_MANAGER
> +	bool
> +	depends on MLX5_SF && MLX5_ESWITCH
> +	default y
> +	help
> +	Build support for subfuction port in the NIC. A Mellanox subfunction
> +	port is managed through devlink.  A subfunction supports RDMA, netdevice
> +	and vdpa device. It is similar to a SRIOV VF but it doesn't require
> +	SRIOV support.

Why is this a separate knob?

And it's not used anywhere AFAICS.