netdev - Re: [PATCH v4 net-next 1/5] net: bonding: Notify ports about their initial state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Dec 2020 18:28:57 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Tobias Waldekranz <tobias@...dekranz.com>
Cc:     davem@...emloft.net, kuba@...nel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 1/5] net: bonding: Notify ports about their
 initial state

On Wed, Dec 16, 2020 at 05:00:52PM +0100, Tobias Waldekranz wrote:
> When creating a static bond (e.g. balance-xor), all ports will always
> be enabled. This is set, and the corresponding notification is sent
> out, before the port is linked to the bond upper.
> 
> In the offloaded case, this ordering is hard to deal with.
> 
> The lower will first see a notification that it can not associate with
> any bond. Then the bond is joined. After that point no more
> notifications are sent, so all ports remain disabled.
> 
> This change simply sends an extra notification once the port has been
> linked to the upper to synchronize the initial state.
> 
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
> Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>

Tested-by: Vladimir Oltean <olteanv@...il.com>

> ---
>  drivers/net/bonding/bond_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 5fe5232cc3f3..ad5192ee1845 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1922,6 +1922,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
>  		goto err_unregister;
>  	}
>  
> +	bond_lower_state_changed(new_slave);
> +
>  	res = bond_sysfs_slave_add(new_slave);
>  	if (res) {
>  		slave_dbg(bond_dev, slave_dev, "Error %d calling bond_sysfs_slave_add\n", res);
> -- 
> 2.17.1
>