netdev - Re: [PATCH net-next 2/4] enetc: don't use macro magic for the readx_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201216192352.5kbjxyhpwgmubm76@skbuf>
Date:   Wed, 16 Dec 2020 19:23:53 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Michael Walle <michael@...le.cc>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexandru Marginean <alexandru.marginean@....com>
Subject: Re: [PATCH net-next 2/4] enetc: don't use macro magic for the
 readx_poll_timeout() callback

On Tue, Dec 15, 2020 at 10:21:58PM +0100, Michael Walle wrote:
> The macro enetc_mdio_rd_reg() is just used in that particular case and
> has a hardcoded parameter name "mdio_priv". Define a specific function
> to use for readx_poll_timeout() instead. Also drop the TIMEOUT macro
> since it is used just once.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
Tested-by: Vladimir Oltean <vladimir.oltean@....com>