netdev - Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mtydbkg9.fsf@waldekranz.com>
Date:   Wed, 16 Dec 2020 20:49:10 +0100
From:   Tobias Waldekranz <tobias@...dekranz.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

On Wed, Dec 16, 2020 at 20:02, Vladimir Oltean <olteanv@...il.com> wrote:
> On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote:
>> +	/* Drivers that benefit from having an ID associated with each
>> +	 * offloaded LAG should set this to the maximum number of
>> +	 * supported IDs. DSA will then maintain a mapping of _at
>> +	 * least_ these many IDs, accessible to drivers via
>> +	 * dsa_tree_lag_id().
>            ~~~~~~~~~~~~~~~
>            you named it dsa_lag_id() in the end.
>
>> +	 */
>> +	unsigned int		num_lag_ids;
> [...]
>> +	/* No IDs left, which is OK. Some drivers do not need it. The
>> +	 * ones that do, e.g. mv88e6xxx, will discover that
>> +	 * dsa_tree_lag_id returns an error for this device when
>            ~~~~~~~~~~~~~~~
>            same thing here.
>
>> +	 * joining the LAG. The driver can then return -EOPNOTSUPP
>> +	 * back to DSA, which will fall back to a software LAG.
>> +	 */

Right, will fix!