netdev - Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201216132606.27201e16@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Dec 2020 13:26:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lijun Pan <ljp@...ux.ibm.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into
 do_reset

On Tue, 15 Dec 2020 02:30:08 -0600 Lijun Pan wrote:
> Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
> linkwatch_event can run") introduced do_change_param_reset function to
> solve the rtnl lock issue. Majority of the code in do_change_param_reset
> duplicates do_reset. Also, we can handle the rtnl lock issue in do_reset
> itself. Hence merge do_change_param_reset back into do_reset to clean up
> the code.
> 
> Signed-off-by: Lijun Pan <ljp@...ux.ibm.com>
> ---
> This patch was accepted into net-next as 16b5f5ce351f but was reverted
> in 9f32c27eb4fc to yield to other under-testing patches. Since those
> bug fix patches are already accepted, resubmit this one.

The merge window has started now, and we're merging net into net-next
pretty much every week, so this could have been done sooner. Let's wait
for net-next to reopen.