netdev - Re: [PATCH net] ethtool: fix error paths in ethnl_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201216133138.7ec4ddde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Dec 2020 13:31:38 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org,
        LiLiang <liali@...hat.com>
Subject: Re: [PATCH net] ethtool: fix error paths in ethnl_set_channels()

On Tue, 15 Dec 2020 11:09:21 +0100 Michal Kubecek wrote:
> On Tue, Dec 15, 2020 at 10:08:10AM +0100, Ivan Vecera wrote:
> > Fix two error paths in ethnl_set_channels() to avoid lock-up caused
> > but unreleased RTNL.
> > 
> > Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET request")
> > Cc: Michal Kubecek <mkubecek@...e.cz>
> > Reported-by: LiLiang <liali@...hat.com>
> > Signed-off-by: Ivan Vecera <ivecera@...hat.com>
>
> Oh, the joys of mindless copy and paste... :-(

I wish sparse was able to catch rtnl_lock leaks. I tried to annotate
it a couple of weeks back but couldn't get it to work well even within
rtnetlink.c

> Reviewed-by: Michal Kubecek <mkubecek@...e.cz>

Applied, thanks!