netdev - RE: [net-next v5 11/15] net/mlx5: SF, Add port add delete functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB4322526F90E73A5EB388CA9DDCC50@BY5PR12MB4322.namprd12.prod.outlook.com>
Date:   Wed, 16 Dec 2020 05:31:15 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jason Gunthorpe <jgg@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>,
        "david.m.ertman@...el.com" <david.m.ertman@...el.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "kiran.patil@...el.com" <kiran.patil@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Vu Pham <vuhuong@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: RE: [net-next v5 11/15] net/mlx5: SF, Add port add delete
 functionality



> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, December 16, 2020 6:21 AM
> 
> On Tue, 15 Dec 2020 01:03:54 -0800 Saeed Mahameed wrote:
> > To handle SF port management outside of the eswitch as independent
> > software layer, introduce eswitch notifier APIs so that upper layer
> > who wish to support sf port management in switchdev mode can perform
> > its
> 
> Could you unpack this? What's the "upper layer" software in this context?
>
Upper layer in this context = sf management layer within the mlx5 driver which implements devlink port add/del callbacks and state handling.
 
> > task whenever eswitch mode is set to switchdev or before eswitch is
> > disabled.
> 
> How does SF work if eswich is disabled?
> 
It doesn't.
when eswitch is disabled, all SF ports gets destroyed through the eswitch event notifier.

> > Initialize sf port table on such eswitch event.
> >
> > Add SF port add and delete functionality in switchdev mode.
> > Destroy all SF ports when eswitch is disabled.
> > Expose SF port add and delete to user via devlink commands.