netdev - Re: [PATCH bpf-next 2/2] net: xdp: introduce xdp_build_skb_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <434e65f4-0b29-3bfb-b5d3-7eebcdd791db@gmail.com>
Date:   Thu, 17 Dec 2020 22:12:18 +0900
From:   Toshiaki Makita <toshiaki.makita1@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, ast@...nel.org,
        daniel@...earbox.net, brouer@...hat.com,
        lorenzo.bianconi@...hat.com
Subject: Re: [PATCH bpf-next 2/2] net: xdp: introduce xdp_build_skb_from_frame
 utility routine

On 2020/12/17 3:38, Lorenzo Bianconi wrote:
> Introduce xdp_build_skb_from_frame utility routine to build the skb
> from xdp_frame. Respect to __xdp_build_skb_from_frame,
> xdp_build_skb_from_frame will allocate the skb object. Rely on
> xdp_build_skb_from_frame in veth driver.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Thanks.
It seems you added missing metadata support in veth_xdp_rcv_one()?
It might be better to note that in the commitlog.

The code looks fine to me.

Reviewed-by: Toshiaki Makita <toshiaki.makita1@...il.com>