netdev - Re: [PATCH net-next v5] udp:allow UDP cmsghdrs through io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5869aae1-400c-94a4-523e-e015f386f986@kernel.dk>
Date:   Thu, 17 Dec 2020 08:49:23 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Victor Stewart <v@...etag.social>, io-uring@...r.kernel.org,
        soheil@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring

On 12/16/20 3:56 PM, Victor Stewart wrote:
> This patch adds PROTO_CMSG_DATA_ONLY to inet_dgram_ops and inet6_dgram_ops so that UDP_SEGMENT (GSO) and UDP_GRO can be used through io_uring.
> 
> GSO and GRO are vital to bring QUIC servers on par with TCP throughputs, and together offer a higher
> throughput gain than io_uring alone (rate of data transit
> considering), thus io_uring is presently the lesser performance choice.
> 
> RE http://vger.kernel.org/lpc_net2018_talks/willemdebruijn-lpc2018-udpgso-paper-DRAFT-1.pdf,
> GSO is about +~63% and GRO +~82%.
> 
> this patch closes that loophole.

LGTM

Acked-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe