netdev - Re: [PATCH] bpf: remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Dec 2020 16:16:13 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] bpf: remove unused including <linux/version.h>

On Tue, Dec 15, 2020 at 6:47 PM Tian Tao <tiantao6@...ilicon.com> wrote:
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> ---
>  kernel/bpf/syscall.c | 1 -
>  1 file changed, 1 deletion(-)
>

Probably a left over since times kprobe programs were required to
specify expected kernel version.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 4caf06f..c3bb03c8 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -17,7 +17,6 @@
>  #include <linux/fs.h>
>  #include <linux/license.h>
>  #include <linux/filter.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/idr.h>
>  #include <linux/cred.h>
> --
> 2.7.4
>