netdev - Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201218121627.603329b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Dec 2020 12:16:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ben Greear <greearb@...delatech.com>,
        Luca Coelho <luciano.coelho@...el.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: net: tso: add UDP segmentation support: adds regression for
 ax200 upload

On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote:
> On 12/17/20 10:20 AM, Eric Dumazet wrote:
> > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear <greearb@...delatech.com> wrote:  
> >> It is the iwlwifi/mvm logic that supports ax200.  
> > 
> > Let me ask again :
> > 
> > I see two different potential call points :
> > 
> > drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1529:
> > tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);
> > drivers/net/wireless/intel/iwlwifi/queue/tx.c:427:
> > tso_build_hdr(skb, hdr_page->pos, &tso, data_left, !total_len);
> > 
> > To the best of your knowledge, which one would be used in your case ?
> > 
> > Both are horribly complex, I do not want to spend time studying two
> > implementations.  
> 
> It is the queue/tx.c code that executes on my system, verified with
> printk.

Not sure why Intel's not on CC here. 

Luca, is the ax200 TSO performance regression with recent kernel on your
radar?