lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 18 Dec 2020 14:58:35 +0100
From:   Ilya Dryomov <>
To:     Jakub Kicinski <>
Cc:     Zheng Yongjun <>,
        Jeff Layton <>,
        "David S. Miller" <>,
        Ceph Development <>,
        netdev <>
Subject: Re: [PATCH net-next] ceph: Delete useless kfree code

On Thu, Dec 17, 2020 at 2:25 AM Jakub Kicinski <> wrote:
> On Wed, 16 Dec 2020 21:02:39 +0800 Zheng Yongjun wrote:
> > The parameter of kfree function is NULL, so kfree code is useless, delete it.
> >
> > Signed-off-by: Zheng Yongjun <>
> To be clear the subject tags is misleading we're not taking this
> into the networking tree, ceph folk please go ahead :)

I still didn't get the original patch for some reason, but looking at

the kfree is not useless.  If ceph_decode_need() fails, the array needs
to be freed, so we are not taking this into the ceph tree either ;)



Powered by blists - more mailing lists