netdev - Re: [PATCH net-next] ceph: Delete useless kfree code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Dec 2020 14:58:35 +0100
From:   Ilya Dryomov <idryomov@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        Jeff Layton <jlayton@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ceph: Delete useless kfree code

On Thu, Dec 17, 2020 at 2:25 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 16 Dec 2020 21:02:39 +0800 Zheng Yongjun wrote:
> > The parameter of kfree function is NULL, so kfree code is useless, delete it.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
>
> To be clear the subject tags is misleading we're not taking this
> into the networking tree, ceph folk please go ahead :)

I still didn't get the original patch for some reason, but looking at

  https://lists.openwall.net/netdev/2020/12/16/163

the kfree is not useless.  If ceph_decode_need() fails, the array needs
to be freed, so we are not taking this into the ceph tree either ;)

Thanks,

                Ilya