lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 17:35:18 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Calvin Johnson <calvin.johnson@....nxp.com> Cc: Grant Likely <grant.likely@....com>, "Rafael J . Wysocki" <rafael@...nel.org>, Jeremy Linton <jeremy.linton@....com>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Russell King - ARM Linux admin <linux@...linux.org.uk>, Cristi Sovaiala <cristian.sovaiala@....com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>, Ioana Ciornei <ioana.ciornei@....com>, Madalin Bucur <madalin.bucur@....nxp.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Marcin Wojtas <mw@...ihalf.com>, Pieter Jansen Van Vuuren <pieter.jansenvv@...boosystems.io>, Jon <jon@...id-run.com>, "linux.cj" <linux.cj@...il.com>, Laurentiu Tudor <laurentiu.tudor@....com>, Diana Madalina Craciun <diana.craciun@....com>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, netdev <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [net-next PATCH v2 06/14] net: mdiobus: Introduce fwnode_mdiobus_register_phy() On Fri, Dec 18, 2020 at 7:34 AM Calvin Johnson <calvin.johnson@....nxp.com> wrote: > > On Tue, Dec 15, 2020 at 07:33:40PM +0200, Andy Shevchenko wrote: > > On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson > > <calvin.johnson@....nxp.com> wrote: ... > > > + /* phy->mii_ts may already be defined by the PHY driver. A > > > + * mii_timestamper probed via the device tree will still have > > > + * precedence. > > > + */ > > > > > + if (mii_ts) > > > + phy->mii_ts = mii_ts; > > > > How is that defined? Do you need to do something with an old pointer? > > As the comment says, I think PHY drivers which got invoked before calling > of_mdiobus_register_phy() may have defined phy->mii_ts. What I meant here is that the old pointer might need some care (freeing?). > > > + } -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists