lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Dec 2020 09:07:13 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, DENG Qingfang <dqfext@...il.com> Cc: netdev@...r.kernel.org, linux-mediatek@...ts.infradead.org, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Russell King <linux@...linux.org.uk>, Greg Ungerer <gerg@...nel.org>, Rene van Dorst <opensource@...rst.com>, John Crispin <john@...ozen.org> Subject: Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible On 12/19/2020 8:26 AM, Andrew Lunn wrote: >> --- a/drivers/net/dsa/mt7530.c >> +++ b/drivers/net/dsa/mt7530.c >> @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = { >> }; >> >> static const struct of_device_id mt7530_of_match[] = { >> - { .compatible = "mediatek,mt7621", .data = &mt753x_table[ID_MT7621], }, >> + { .compatible = "mediatek,mt7621-gsw", .data = &mt753x_table[ID_MT7621], }, >> { .compatible = "mediatek,mt7530", .data = &mt753x_table[ID_MT7530], }, >> { .compatible = "mediatek,mt7531", .data = &mt753x_table[ID_MT7531], }, >> { /* sentinel */ }, > > This will break backwards compatibility with existing DT blobs. You > need to keep the old "mediatek,mt7621", but please add a comment that > it is deprecated. Besides, adding -gsw would make it inconsistent with the existing matching compatible strings. While it's not ideal to have the same top-level SoC compatible and having another sub-node within that SoC's DTS have the same compatible, given this would be break backwards compatibility, cannot you stay with what is defined today? -- Florian
Powered by blists - more mailing lists